Dedup StreamWriter/StreamReader container helpers via shared element …

[drsnuggles8]

…helper

[coderabbitai]

Warning

Review limit reached

@drsnuggles8, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 20 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 69b30271-f5aa-4b78-88ff-6a1ad0808bf5

📥 Commits

Reviewing files that changed from the base of the PR and between 0f95ec8 and 70713f5.

📒 Files selected for processing (4)

• OloEngine/src/OloEngine/Serialization/StreamReader.h
• OloEngine/src/OloEngine/Serialization/StreamWriter.h
• OloEngine/tests/CMakeLists.txt
• OloEngine/tests/Serialization/StreamHelpersTest.cpp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[drsnuggles8]

🤖 Self-review (finish-pr) @ 70713f59443cd5344631d31792b022d38922f623

Reviewed the full PR diff at high effort (traced every caller + pinned the wire format + ran the new tests locally).

• Findings: 0 real.
• Verified:
  • Behavior-preserving for every previously-supported instantiation. The only production caller, FontSerializer::WriteArray(std::vector<FontCodepointRange>), is trivially-copyable and dispatches identically through the new WriteElement.
  • WriteElement/ReadElement correctly made private; the public API (WriteMap/ReadMap/WriteArray/ReadArray) is unchanged.
  • Wire format unchanged & pinned by new byte-level tests: u32 count prefix for arrays/maps, u64-length-prefixed strings (matches StreamWriter::WriteString), raw bytes for trivially-copyable, static Serialize/Deserialize for class elements.
  • Bonus capability (not a regression): now also handles std::map<std::string, …> keys and string map values — cases the old code couldn't even compile.
  • 13/13 new StreamHelpers.* tests pass locally; CI build + ASan/LSan/TSan/UBSan all green on this SHA.
• Dismissed: the unified WriteMap(const Map&)/ReadMap(Map&) is now an unconstrained template — but a non-pair container (e.g. std::set) fails to compile on the structured binding rather than silently misbehaving, so a concept constraint would be gold-plating, not a correctness fix.
• CI note: the only red check is the non-required SonarCloud Scan, which timed out at the 6h cap. Successful SonarCloud runs take 272–357 min (cap is 360) — a chronic infra flake unrelated to this 4-file dedup; does not block merge.