Skip to content

chore: update header files for improved organization and clarity#402

Open
drsnuggles8 wants to merge 1 commit into
masterfrom
feature/renderer-ibl-bake-speedup
Open

chore: update header files for improved organization and clarity#402
drsnuggles8 wants to merge 1 commit into
masterfrom
feature/renderer-ibl-bake-speedup

Conversation

@drsnuggles8

@drsnuggles8 drsnuggles8 commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved environment lighting pack handling so saved and loaded lighting settings now match the updated configuration format.
    • Removed an outdated multithreading option from environment lighting settings, since generation now runs in a single rendering context.
    • Refined environment lighting generation to use the standard rendering path, helping keep baked results consistent across irradiance, prefilter, and BRDF LUT outputs.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9471e280-e351-416d-922b-5e865672e771

📥 Commits

Reviewing files that changed from the base of the PR and between 82a04b8 and df7152c.

📒 Files selected for processing (4)
  • OloEngine/src/OloEngine/Asset/AssetSerializer.cpp
  • OloEngine/src/OloEngine/Renderer/EnvironmentMap.h
  • OloEngine/src/OloEngine/Renderer/IBLPrecompute.cpp
  • OloEngine/src/OloEngine/Renderer/IBLPrecompute.h
💤 Files with no reviewable changes (1)
  • OloEngine/src/OloEngine/Asset/AssetSerializer.cpp

📝 Walkthrough

Walkthrough

The PR removes EnableMultithreading from IBLConfiguration, updates IBL bake helpers to call the base render functions directly, and changes asset-pack serialization to write and read the updated IBL fields.

Changes

IBL bake and pack layout

Layer / File(s) Summary
IBL contract and helper surface
OloEngine/src/OloEngine/Renderer/EnvironmentMap.h, OloEngine/src/OloEngine/Renderer/IBLPrecompute.h, OloEngine/src/OloEngine/Renderer/IBLPrecompute.cpp
IBLConfiguration drops EnableMultithreading, and the IBLPrecompute declarations and bake comments describe the remaining serial helper path.
Direct IBL render calls
OloEngine/src/OloEngine/Renderer/IBLPrecompute.cpp
The advanced irradiance, prefilter, and BRDF LUT generation paths now call RenderToCubemap(...) and RenderToTexture(...) directly.
Asset-pack IBL layout
OloEngine/src/OloEngine/Asset/AssetSerializer.cpp
The asset-pack serializer and deserializer write and read the new IBL sample and BRDF LUT fields and no longer include EnableMultithreading.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is broadly related to the change set, though it understates the functional IBL serialization and rendering updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant