Remove annotations from related files regardless of exclude_* options#343
Open
jeduardo824 wants to merge 1 commit into
Open
Remove annotations from related files regardless of exclude_* options#343jeduardo824 wants to merge 1 commit into
jeduardo824 wants to merge 1 commit into
Conversation
When a related file type is excluded (e.g. `exclude_tests: true`), `annotaterb models --delete` skipped those files, leaving previously written annotations orphaned with no built-in way to clean them up. ProjectAnnotationRemover reuses RelatedFilesListBuilder, which gates each related type on the `exclude_*` options for both annotation and removal. Add a `for_removal:` flag (default false) that bypasses those guards so removal reaches every related file; the annotate path is unchanged. Removing an annotation from a file that has none is a no-op. Refs drwl#340 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
OdenTakashi
approved these changes
Jun 25, 2026
OdenTakashi
left a comment
OdenTakashi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this. Looks great to me!
However, as I mentioned in issue #340, there is a possibility that a certain usage pattern may no longer work after this change, so I’d like @drwl to take a look at that point.
That said, I don’t think that usage pattern is actually intended, so I’m personally fine with merging this as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a related file type is excluded (e.g.
exclude_tests: true),annotaterb models --deleteskipped those files, leaving previously written annotations orphaned with no built-in way to clean them up.ProjectAnnotationRemover reuses RelatedFilesListBuilder, which gates each related type on the
exclude_*options for both annotation and removal. Add afor_removal:flag (default false) that bypasses those guards so removal reaches every related file; the annotate path is unchanged. Removing an annotation from a file that has none is a no-op.Refs #340