test: add Rails version matrix and Rails 8 datetime template overrides#350
Closed
OdenTakashi wants to merge 4 commits into
Closed
test: add Rails version matrix and Rails 8 datetime template overrides#350OdenTakashi wants to merge 4 commits into
OdenTakashi wants to merge 4 commits into
Conversation
Pass RAILS_VERSION through dummyapp Gemfile and CI matrix so integration specs can be exercised against supported Rails minors before aligning specs. Co-authored-by: Cursor <cursoragent@cursor.com>
Pass RAILS_VERSION through dummyapp and CI so integration specs run across supported Rails minors, and select pre8 vs rails8 golden templates by major version to match datetime default formatting changes in Rails 8. Co-authored-by: Cursor <cursoragent@cursor.com>
Rails 8 requires sqlite3 >= 2.1 while older Rails minors keep the existing 1.x constraint so integration jobs can boot on both sides of the boundary. Co-authored-by: Cursor <cursoragent@cursor.com>
Fall back to pre8 templates for unchanged files so only the four specs with datetime default differences need rails8-specific golden files. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I accidentally opened an unnecessary PR.