Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3585
Drop fleet default min resources both for run provisioning and instance provisioning paths. The main benefit is that users do not need to specify twice resources in run and fleet configurations unless they need to put extra constraints. Previously, to use instances with cpu, memory or disk lower than defaults, you had to lower the resources twice, and this could be hard to discover.
The new fleets behavior is that users get smallest available offers by default and specify
resourcesif they need to lift/constraint the requirements. The run default min resources left unchanged to avoid provisioning runs on small offers by default.Here's the new first fleet offers (without
resources)For lambda and vultr disk size is tied to instance and cannot be changed so it's different than default 100GB fallback.
Existing fleets continue to have the defaults set. The change applies only to new fleets.