Skip to content

Disable autofill instead of crashing on exceptions#8163

Draft
CrisBarreiro wants to merge 1 commit intodevelopfrom
feature/cris/autofill/disable-autofill-instead-of-crashing
Draft

Disable autofill instead of crashing on exceptions#8163
CrisBarreiro wants to merge 1 commit intodevelopfrom
feature/cris/autofill/disable-autofill-instead-of-crashing

Conversation

@CrisBarreiro
Copy link
Copy Markdown
Collaborator

@CrisBarreiro CrisBarreiro commented Mar 31, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1203822806345703/task/1213571673775022?focus=true

Description

Steps to test this PR

Feature 1

  • Fresh install
  • Create a password for fill.dev
  • Apply patch, install again
  • Open fill.dev
  • Check app doesn't crash

Patches

Subject: [PATCH] Force exception on read
---
Index: autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/store/keys/SecureStorageKeyStore.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/store/keys/SecureStorageKeyStore.kt b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/store/keys/SecureStorageKeyStore.kt
--- a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/store/keys/SecureStorageKeyStore.kt	(revision c626e494540a136b957a810912bb7e281aba5c3d)
+++ b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/store/keys/SecureStorageKeyStore.kt	(date 1774962387460)
@@ -325,6 +325,9 @@
     }
 
     override suspend fun getKey(keyName: String): ByteArray? {
+        if (keyName != "KEY_L1KEY") {
+            throw SecureStorageException.InternalSecureStorageException("test")
+        }
         return withContext(dispatcherProvider.io()) {
             val harmonyFlags = harmonyFlags()
 

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro force-pushed the feature/cris/autofill/disable-autofill-instead-of-crashing branch from ebdd2d0 to 0bfea93 Compare April 13, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant