fix: correct Zed web search tool name to search_web#1853
Merged
Conversation
Zed's built-in web-search tool is named search_web, not web_search. The permissions adapter mapped websearch to web_search, so generated entries were silently ignored by Zed and real search_web entries did not round-trip back to websearch. Closes #1850 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zed's built-in web-search tool is named
search_web, notweb_search. The Zed permissions adapter mapped the canonicalwebsearchcategory toweb_search, so:agent.tool_permissions.tools.web_searchentry was silently ignored by Zed, andsearch_webentry did not round-trip back towebsearchon reverse parse.This changes the mapping in
src/features/permissions/zed-permissions.tstowebsearch: "search_web". The reverse map is derived automatically, so no other code change is needed.Verification
Tool name confirmed against Zed's authoritative docs:
search_web)The other mappings (
bash→terminal,read→read_file,edit→edit_file,webfetch→fetch) were verified correct and left unchanged.Test
Added a round-trip test asserting
websearch ⇄ search_webinzed-permissions.test.ts.Closes #1850
🤖 Generated with Claude Code