Repository navigation
Conversation
…reatedAt GET /snapshots returns only snapshotID and names, so a caller cannot see a snapshot templates specs or age without a second lookup. Add four optional fields to SnapshotInfo, populated from the row ListTeamSnapshotTemplates already returns - no new DB query: - cpuCount <- Vcpu - memoryMB <- RamMb - diskSizeMB <- TotalDiskSizeMb (nullable; omitted when not recorded) - createdAt <- CreatedAt All four are optional/omitempty, so the change is backward compatible. The large api.gen.go diff is the regenerated embedded-spec blob; no handwritten Go beyond the SnapshotInfo struct changes. This is the low-risk slice of the earlier snapshot work (e2b-dev#3457); the GET/DELETE single-snapshot CRUD from that PR is left out pending a maintainer design call (tracked separately).
AdaAibaby
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
October 22, 2026 05:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /snapshotscurrently returns onlysnapshotIDandnames, so a caller cannot see a snapshot template's specs or age without a second lookup. This adds four optional fields toSnapshotInfo, populated from the rowListTeamSnapshotTemplatesalready returns — no new DB query:cpuCountVcpumemoryMBRamMbdiskSizeMBTotalDiskSizeMb(nullable; omitted when not recorded)createdAtCreatedAtAll four are
omitempty, so the change is backward compatible.Scope
This is the low-risk slice of the earlier snapshot work (#3457). The
GET/DELETE /snapshots/{snapshotID}single-snapshot CRUD from that PR is intentionally not included here — whether the API should grow that surface is a maintainer design call, tracked in a separate issue. This PR only enriches the existing list response.Notes
api.gen.godiff is the regeneratedembedded-specblob (base64 of the whole OpenAPI doc, rewritten on any spec change); the only hand-relevant Go change is theSnapshotInfostruct gaining four fields.go build ./...,go vet, andgofmtpass. The snapshot handler tests require a Postgres test DB (PG_TEST_DATABASE_URL) and run in CI.