Skip to content

fix(api): remove ReadTimeout to prevent premature body-read failures under high concurrency (rebase of #3416) #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdaAibaby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): remove ReadTimeout to prevent premature body-read failures under high concurrency (rebase of #3416) #3722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/api/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const (
maxUploadLimit = 1 << 24 // 16 MiB

maxReadHeaderTimeout = 5 * time.Second
maxReadTimeout = 10 * time.Second
// maxWriteTimeout must exceed cfg.RequestTimeout so the request context
// cancels before the server's write deadline kills the connection.
maxWriteTimeout = 75 * time.Second
Expand Down Expand Up @@ -251,7 +250,6 @@ func NewGinServer(ctx context.Context, config cfg.Config, tel *telemetry.Client,

// Configure request timeouts.
ReadHeaderTimeout: maxReadHeaderTimeout,
ReadTimeout: maxReadTimeout,
WriteTimeout: maxWriteTimeout,

// Configure timeouts to be greater than the proxy timeouts.
Expand Down