Repository navigation
fix(checkout): fail closed on unknown OPTIONAL Guard and pending lock-info - #88
Merged
Merged
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up after Docker #48, Server #41, Hub #87/#50 merged. Two concrete contract holes remained:
cf_edit_guardwas reported by Hub lock-info ascheckout_supported=false, indistinguishable from an OFF repo, so the UI could start optimistic editing that native Server necessarily rejects.checkout=nullas not checked out and enabled ordinary editing.Minimal changes (Hub only)
checkout_for_repo(), add lightweightcheckout_selected()/checkout_unavailable()to distinguish selected-but-broken Guard from unselected OFF.GET lock-inforeturns 503 GUARD_UNAVAILABLE, andPOST edit/v1/openrefuses new optimistic/exclusive tickets. Read tickets still work. OFF still returns explicitcheckout_supported=falsewithout Guard metadata/SQL.Verification/rollout
This is source-only and remains separate from Agent2's real Windows/macOS E2E issues #10/#1. No Server, Docker, Rust protocol, or database changes. Do not conflate quick CI with live DEV acceptance.