Repository navigation
docs(acl): describe the two-phase native ACL check - #91
Merged
Merged
Conversation
#42 moved native commit authorization into a pre-lock preflight and keeps only the ACL row/revision proof inside Branch(master). Update the NativeACLCheck docstring, which still claimed the Hub decision runs under the Branch lock at final commit. Comment-only change; no behaviour change. Refs eaopen/cloudfile-server#43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comment-only update to
NativeACLCheck's docstring. It still claimed native code invokes theHub ACL check "under Branch(master) at final commit", which stopped being true with
eaopen/cloudfile-server#42:
Branch(master)transaction only re-reads the bounded ACL row/revision proof.Keeping the old sentence would invite new callers to add Hub HTTP inside the Branch
transaction, which is exactly the lock/HTTP ordering fixed by #42 and tracked for cf-edit in
eaopen/cloudfile-server#43.
Verification
Docstring only;
python3 -m py_compile cloudfile_ext/v2/acl_http.pypasses. No behaviour change.Refs eaopen/cloudfile-server#42, eaopen/cloudfile-server#43.