Repository navigation
Conversation
Author
|
Closed per owner decision: the fix itself ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-directory uploads previously failed because scoped upload tickets reused a file-download path validator that rejects
/. The production fix is already ondevinf4f984b; this PR adds the missing regression coverage without duplicating or changing that fix.The test compiles the actual C upload/download validators and checks 21 path cases: upload root acceptance, download root rejection, normal and Unicode paths, traversal, separators, control characters, invalid UTF-8 and length boundaries. It also checks that each RPC calls its intended validator. The testing guide includes the command.
Validation:
python3 tests/test_scoped_upload_paths.pyandgit diff --checkpassed. No full Server build, live authorization/upload test or deployment was performed. Root-level files such as/file.pdfremain valid download targets;/itself is a directory, not a single-file download target.