Repository navigation
fix(acl): distinguish file and directory entries in native batched read checks - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The native C directory-listing batch previously sent every dirent as
kind=dirto the Hub's shared Authority, including regular files. Read permissions for files must follow the containing directory; directory entries must use their own path. Read/write actions continue using the existing Hub/Redis ACL snapshot and identical policy resolver.modeand sendkind=filefor regular files,kind=dirfor directories.Related compatibility rollout: Hub bulk PR eaopen/cloudfile-hub#52 and EAP PR https://github.com/jcetech/etech-eap/pull/21. Independent of previous Server retry/lock fixes #27/#28.
Verification
The lightweight CI test checks mode extraction, kind discrimination and preservation of batch verdict checks. Before merging, check a mixed file/folder page, invisible subdirectory, shared-root boundary and file download permissions against real native C + Hub.