Fix flaky local assortativity test#175
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the random node attributes from
TestLocalAssort.test_karatecluband replaces them with deterministic, contiguous labels.The previous test used:
without setting a random seed. This could randomly produce a non-contiguous label set such as
[0, 1, 2, 3, 5].localAssortassumes node attribute indices are contiguous and start from 0, which is also documented in the function docstring. When the generated labels skipped a category but still included label5, the sparse indicator matrix was created with too few columns and SciPy raised:Root Cause
The failing GitHub Actions run on Python 3.12 was caused by test randomness, not by the HIF fix and not by a Python 3.12-specific implementation regression. The 3.12 job happened to sample a bad non-contiguous label set; other matrix jobs sampled valid data and passed.
Changes
randomimport.This keeps six categories in the test while guaranteeing labels are contiguous from 0 to 5.
Validation
Local pytest was intentionally not run per maintainer request. GitHub Actions will validate the full pytest matrix automatically for this PR and again on merge to
pybind11.Lightweight local check run:
git diff --check