Changes for fix Warnings...#2
Open
Phosphorus-M wants to merge 6 commits into
Open
Conversation
Fixed the message "Warning: count()" In the index when is installed phpbb2 and you not have a moderator
Phpbb2.0.25
Owner
|
Thank you for the fix Fernando! I'm going to merge it (without the captcha change though since it's unrelated). |
ebourg
reviewed
Apr 19, 2019
| } | ||
|
|
||
| if ( count($forum_moderators[$forum_id]) > 0 ) | ||
| if ( count($forum_moderators[$forum_id] ?? $forum_moderators ) > 0 ) |
Owner
There was a problem hiding this comment.
Would this work instead? :
if (isset($forum_moderators[$forum_id]) && count($forum_moderators[$forum_id]) > 0)
Using $forum_moderators as the default argument for count()when the forum_id is missing isn't very intuitive.
Author
|
This is better 🤙 ... or no... |
|
FWIW IntegraMOD ended up with a |
Owner
|
@vendethiel Would you want to contribute the fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the message "Warning: count()" In the index when is installed phpbb2.
I have a this messages in the Index and the admin panel.
And i fix the messages with this branch...