Add TypeScript types entry to package.json#3
Open
ktarmyshov wants to merge 1 commit intoechecsjs:mainfrom
Open
Add TypeScript types entry to package.json#3ktarmyshov wants to merge 1 commit intoechecsjs:mainfrom
ktarmyshov wants to merge 1 commit intoechecsjs:mainfrom
Conversation
Better compatibility for "moduleResolution": "node" tsconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Adrian!
I found your library and wanted to use it in my project, but ran into a TypeScript resolution issue because I am using
"moduleResolution": "node".The package already exposes declarations via
exports.types, but adding a top-level"types"field would improve compatibility for TypeScript consumers using older resolver settings. Switching tonodenextis not always a small change, because it also requires updating internal relative imports to include.js.I tested this by adding the following line locally in
node_modules, and it resolved the issue in my project:This seems like a small, non-breaking compatibility improvement that could reduce adoption friction.
Thank you!
Konstantin
Description
Resolve import issue in projects with older
"moduleResolution": "node"setting in tsconfig.json.Type of change
Checklist
pnpm lint && pnpm test && pnpm build)CHANGELOG.mdupdated (for bug fixes and new features)