chore: Turbo Streams/Frame, controller refactor, 100% test coverage#13
Merged
Conversation
…s clickable Each stat card on the dashboard now links directly to its filtered jobs view, queues, or processes page. The release job in CI now creates a GitHub Release with CHANGELOG notes when a version tag is pushed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Individual discard removes the row in place without a full page reload. When the last job on the view is discarded the card swaps to an empty state. HTML fallback (redirect) is preserved for non-Turbo requests. Adds turbo-rails as a gem dependency and explicit require in engine.rb. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…hing Status filter tabs, queue filter links, Discard All button, and pagination are all inside the frame so clicking any of them replaces only the table area without a full page reload. The Jobs h1 stays static above the frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…DELS hash Single hash constant covers both the index query and the execution_model_for! guard, removing two case statements and making the mapping explicit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…pe helper Removes param re-reading and duplicated scope building from destroy and discard_all. Both actions now share the same @status/@Queue setup and delegate filtered scope construction to a single private method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add error rescue path tests for jobs, failed_jobs, and queues controllers. Cover derive_status scheduled and finished branches via show action. Cover authentication block execution and HTTP basic auth fallback. Filter boilerplate application_job and application_record from SimpleCov. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JobsControllerrefactor — twocasestatements replaced withEXECUTION_MODELShash;destroy/discard_allshare abefore_action :set_status_and_queueand afiltered_scopehelperderive_statusbranches, and authentication block all exercised; boilerplate files excluded from SimpleCovTest plan
bundle exec rspec)bin/rubocop)🤖 Generated with Claude Code