feat: multi-database support via connects_to config#43
Merged
Conversation
Adds a `connects_to` setting that, when configured, wraps every engine request in `ActiveRecord::Base.connected_to(...)`. Accepts any kwargs Rails supports — `database:`, `role:`, or `shard:`. Defaults to nil so single-database apps are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connects_toconfig option that wraps every engine request inActiveRecord::Base.connected_to(...)when set; accepts any kwargs Rails supports —database:,role:, orshard:nilso single-database apps are completely unaffectedTest plan
bundle exec rspec spec/solid_queue_web_spec.rb— 2 new examples covering nil default and hash assignmentbundle exec rspec spec/requests/solid_queue_web/dashboard_spec.rb— 2 new examples verifying passthrough (no config) andconnected_tois called when configuredbundle exec rake— full suite (audit + rubocop + rspec), 206 examples, 0 failures, 100% coverage🤖 Generated with Claude Code