feat: sortable columns on jobs, failed jobs, and history#70
Merged
Conversation
Adds server-side ?sort=&direction= params to three queue list views. Sort state is preserved across filter changes, tab switches, and period buttons. A shared sort_header_th helper generates the <th> with aria-sort and direction indicator from a URL proc. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Before: index set 6 params inline then built the scope inline — 18 lines of mixed concerns. destroy duplicated 4 of those same assignments. After: before_action :set_filters handles all param normalization for both actions; job_scope builds the filtered+sorted relation; index drops to 14 lines. priority_options query moved inside format.html so CSV requests skip it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The four identical jobs_path(...) calls in destroy are replaced with a single private method, making each rescue and redirect a one-liner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?sort=and?direction=params to the Jobs, Failed Jobs, and History tables; click any column header to sort ascending or descendingsort_header_thhelper generates accessible<th>elements witharia-sortand ↑/↓ direction indicatorsRefactors included
before_action :set_filtersinJobsControllereliminates duplicated param-normalization betweenindexanddestroyjob_scopeprivate method extracts the filtered+sorted relation out ofindexjobs_return_pathprivate method de-duplicates the four identical redirect targets indestroyTest plan
bundle exec rake)sort: "DROP TABLE")sort/directionparamsCloses #80
🤖 Generated with Claude Code