perf: eliminate N+1 queries on queues index#77
Merged
Conversation
Replace per-queue queue.size (COUNT) and queue.paused? (EXISTS) calls with two batch aggregations pre-computed in QueuesController#index: a single GROUP BY query for ready execution counts and one Pause.pluck for paused state. Reduces query count from O(2N + constant) to O(constant) regardless of the number of queues. View updated to read from the pre-computed hashes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue.sizepreviously calledReadyExecution.queued_as(name).count— oneCOUNTquery per queuequeue.paused?previously calledPause.exists?(queue_name: name)— oneEXISTSquery per queueQueuesController#indexwith two batch queries: a singleGROUP BY queue_nameaggregation for sizes and onePause.pluck(:queue_name)for paused state@queue_sizes[queue.name]and@paused_queue_names.include?(queue.name)insteadTest plan
Closes #76
🤖 Generated with Claude Code