Bulk job selection and discard (#10)#10
Merged
Merged
Conversation
Add checkbox selection to the jobs table with a "Discard Selected" action. Plain HTML form approach (no Stimulus) with a select-all checkbox and per-row checkboxes scoped to DISCARDABLE statuses only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the non-RESTful `discard_selected` collection action with a dedicated `Jobs::SelectionsController#destroy`, routed as a singular resource at DELETE /jobs/selection — the Rails Way. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
data-turbo="false" opts out of Turbo entirely, causing the browser to submit a native form whose hidden authenticity_token can't be verified by the engine. Switching to data-turbo-frame="_top" lets Turbo send the X-CSRF-Token header while still doing a full-page navigation after the discard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jobs::SelectionsController#destroyatDELETE /jobs/selection— the Rails Way (singular resource, proper HTTP verb)data-turbo-frame="_top"(same pattern as Discard All), causing a full-page navigation after the redirectTest plan
bundle exec rspec— 81 examples, 0 failuresbin/rubocop— no offenses🤖 Generated with Claude Code