feat: failed job detail page with inline argument editor and retry#12
Merged
Conversation
Add show action and view to FailedJobsController; FailedJobs::ArgumentsController handles PATCH /failed_jobs/:id/arguments — parses the submitted JSON, updates the job arguments, and retries. Invalid JSON redirects back with an alert. Job class names in the failed jobs list are now links to the detail page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /failed_jobs/:id) showing error info, backtrace, queue/priority metadata, and a monospace argument editorFailedJobs::ArgumentsController(nested singular resourceresource :arguments) — allows editing job arguments as JSON and retrying in one actionSelectionsControllerandArgumentsControllerTest plan
GET /failed_jobs/:idreturns 200, shows job class, error, backtrace, breadcrumb, Retry/Discard buttons, and argument editor formPATCH /failed_jobs/:id/argumentsupdates arguments and retries the job; redirects with alert on invalid JSON or DB errorrescue JSON::ParserErrorpath covered (invalid JSON input)rescue => epath covered inArgumentsController,FailedJobs::SelectionsController(retry and discard), andJobs::SelectionsController🤖 Generated with Claude Code