feat: unify detail page layout and CSS across all three sections#91
Merged
Conversation
- Wrap cache entry detail in sqw-detail-card cards (matches jobs/failed_jobs) - Replace sqw-detail/sqw-detail__row with sqw-dl (one definition list class) - Replace sqw-value-pre with sqw-code-block (one code block class, 400px max-height) - Remove inline margin-top style from failed_jobs/show; use CSS sibling selector instead Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
Summary
sqw-detail-card sqw-detail-section)sqw-detail/sqw-detail__row→sqw-dl) and two near-identical code block classes (sqw-value-pre→sqw-code-block), aligning max-height to 400px throughoutmargin-topstyle on the failed-job arguments card replaced with a CSS sibling-selector rule (.sqw-detail-grid + .sqw-detail-card,.sqw-detail-card + .sqw-detail-card)Test plan
bundle exec rspec— 329 examples, 0 failures🤖 Generated with Claude Code