refactor: extract shared CMSIS to libs/3rdparty/cmsis#445
Conversation
|
Libs under libs/3rdparty mostly have .riminfo files available to be able to check consistency with upstream. Can you provide that one also? |
Fix treefmt CI gate on PR eclipse-openbsw#445. cmake-format collapses target_include_directories arguments onto fewer lines than the manual layout produced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hi @rolandreichweinbmw — quick question before producing the Two options:
Which would you prefer? Also pushed |
I propose (a). Checksumming and providing traceability to a certain upstream version/commit is the whole point of RIM. |
|
@nhuvaoanh123 : We were just asked about the missing RIM support for CMSIS in the Eclipse review process: https://gitlab.eclipse.org/eclipsefdn/emo-team/emo/-/issues/1125 Can you please update the PR regarding |
Fix treefmt CI gate on PR eclipse-openbsw#445. cmake-format collapses target_include_directories arguments onto fewer lines than the manual layout produced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
473d071 to
e758d70
Compare
|
Content-wise, looks good now! Thank you for the update. Formally, can you please update the commit messages according to https://github.com/eclipse-openbsw/openbsw/blob/main/doc/dev/guidelines/commit_message.rst :
|
Move the CMSIS 6.1.0 headers from the s32k1xx BSP into libs/3rdparty/cmsis so future Cortex-M platforms can share the same CMSIS Core files without duplicating the import. The module metadata and NOTICE entry are updated with the new path. The s32k1xx BSP now uses the shared include directory.
Format the updated target_include_directories call so treefmt accepts the CMSIS include path change.
Add .riminfo metadata for the shared CMSIS Core subset. The metadata points to the exact CMSIS_6 commit behind version 6.1.0 and ignores upstream files that are not part of the OpenBSW import.
1f3c015 to
5508d7e
Compare
|
Thanks for the guidance. I updated the commit messages accordingly and removed the AI Co-Authored-By trailers. |
Summary
Moves CMSIS 6.1.0 headers from `platforms/s32k1xx/bsp/bspMcu/include/3rdparty/cmsis/` to `libs/3rdparty/cmsis/` so that future Cortex-M platforms can share the same CMSIS core without duplication.
This is the preparatory refactor referenced in PR #413 discussion and the strategy doc under `docs/stm32-pr-strategy.md` on the STM32 series branch.
Changes
Non-goals
Test plan
🤖 Generated with Claude Code