GH-5807 Recover LMDB readers safely when maxreaders is full#5806
Merged
hmottestad merged 4 commits intomainfrom May 2, 2026
Merged
GH-5807 Recover LMDB readers safely when maxreaders is full#5806hmottestad merged 4 commits intomainfrom
hmottestad merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5807
Briefly describe the changes proposed in this PR:
Fixes #5807.
MDB_READERS_FULLby closing pooled reset-mode readers, checking for dead LMDB readers, waiting briefly for tracked reader owners, and retrying.TxnManagerregressions proving reader-full recovery and manager reset do not abort a tracked inactive transaction that is still owned by a live caller.Root cause: timed-out server query work could leave LMDB read transactions occupying reader slots. Once LMDB reached
maxreaders, subsequent reads failed withMDB_READERS_FULL. Reader recovery must reclaim only handles that are safe to own, such as pooled reset-mode readers or dead process/thread readers reported by LMDB; aborting a tracked inactive transaction can invalidate a live caller's handle.Verification:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)