Use setup-qnx-sdp composite action in qnx-build workflow

[MTomBosch]

This pull request updates the QNX build workflow to improve maintainability and reliability by switching to a reusable action for QNX SDP setup, updating dependencies, and refining environment variable usage. The changes streamline QNX license and credential management, making the workflow more robust and easier to maintain.

ATTENTION: The reference to the setup-qnx-sdp action must be changed once eclipse-score/cicd-actions#2 is merged.

This was tested by putting it into a company internal repository workflow yml file replacing the current yml logic and running it. Result is that all worked as expected.

[AlexanderLanin]

I guess this PR needs a new hash for the setup qnx action

[4og]

Will this workflow be deprecated because one can use https://github.com/eclipse-score/cicd-actions/tree/main/setup-qnx-sdp action directly?

[AlexanderLanin]

@4og that's what I'm wondering as well. But for now we can simplify this workflow to use the action. It's still a potentially useful wrapper... whether its worth it... we'll see.

[AlexanderLanin]

AI-assisted review (Claude):

Critical: 0, Important: 1, Suggestions: 1

Good simplification — delegating QNX setup to a composite action removes ~50 lines of inline shell without losing any behavior. The !cancelled() fix (replacing always()), SHA-pinned action dependencies, and moving credential setup into the action are all correct improvements.

Main gate — see inline comment on the setup-qnx-sdp step: the action is currently pinned by a date-hash commit, not a released tag. Per the PR description, this must be updated once eclipse-score/cicd-actions/pull/2 merges. Enforce this as a merge prerequisite.

Side note: The removed Cleanup QNX license step had a pre-existing YAML indentation bug in the original — run: was outdented to the sequence level, outside the step definition, so the cleanup was never actually executing. Removing it here is correct; the composite action presumably handles cleanup.

---

Generated by Claude