Extend GenericSkeletonEvent to trigger EventUpdate notification#409
Open
Rahul-Sutariya wants to merge 1 commit into
Conversation
crimson11
requested changes
May 13, 2026
Rahul-Sutariya
force-pushed
the
extend_genericSkeletonEvent_to_trigger_eventUpdate_notification
branch
3 times, most recently
from
00b4760 to
f85c0da
Compare
Rahul-Sutariya
force-pushed
the
extend_genericSkeletonEvent_to_trigger_eventUpdate_notification
branch
from
f85c0da to
0c9706a
Compare
Rahul-Sutariya
requested review from
LittleHuba,
bemerybmw,
castler,
hoe-jo and
limdor
as code owners
crimson11
requested changes
May 20, 2026
| CreateGenericSkeletonEvent( | ||
| fake_element_fq_id_, fake_event_name_, max_samples, max_subscribers, enforce_max_samples); | ||
|
|
||
| // And receive handlers reported as registered for both quality levels |
Contributor
There was a problem hiding this comment.
OK. Now I'm a bit nitpicky here ;)
The comment above/before the two EXPECT_CALL should be
expect, that EventNotificationExistenceChangedCallbacks are registered for both ASIL levels at message_passing
| has_handlers_callback(true); | ||
| })); | ||
|
|
||
| // When offering the event and calling Notify |
Contributor
There was a problem hiding this comment.
this should be just
when offering the event
|
|
||
| // When offering the event and calling Notify | ||
| std::ignore = generic_skeleton_event_->PrepareOffer(); | ||
| EXPECT_CALL(message_passing_mock_, NotifyEvent(QualityType::kASIL_QM, fake_element_fq_id_)); |
Contributor
There was a problem hiding this comment.
then comment before these two EXPECT_CALL
expect, that NotifyEvent gets called at message-passing for both ASIL-levels
| std::ignore = generic_skeleton_event_->PrepareOffer(); | ||
| EXPECT_CALL(message_passing_mock_, NotifyEvent(QualityType::kASIL_QM, fake_element_fq_id_)); | ||
| EXPECT_CALL(message_passing_mock_, NotifyEvent(QualityType::kASIL_B, fake_element_fq_id_)); | ||
| auto result = generic_skeleton_event_->Notify(); |
Contributor
There was a problem hiding this comment.
comment above
when Notify() gets called on the GenericSkeletonEvent
| EXPECT_CALL(message_passing_mock_, NotifyEvent(QualityType::kASIL_B, fake_element_fq_id_)); | ||
| auto result = generic_skeleton_event_->Notify(); | ||
|
|
||
| // Then message passing is notified for both quality levels |
Contributor
There was a problem hiding this comment.
here the comment should then rather be
... and that the Notify() call had no errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.