Skip to content

Make sure that no new warnings are introduced #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
limdor wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −0
Draft

Make sure that no new warnings are introduced #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8a313d
Make explicit that STATE_COUNT is also an invalid state
limdor May 19, 2026
f55eb71
Make sure that no new warnings are introduced
limdor May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,25 @@ build --incompatible_strict_action_env
test --test_output=errors
build --experimental_retain_test_configuration_across_testonly #https://github.com/bazelbuild/bazel/issues/6842

# Do not treat as errors the warnings from external libraries that are known
build --per_file_copt=external/.*json_schema_validator.*@-Wno-error=switch
build --host_per_file_copt=external/.*json_schema_validator.*@-Wno-error=switch
build --per_file_copt=external/.*json_schema_validator.*@-Wno-error=switch-enum
build --host_per_file_copt=external/.*json_schema_validator.*@-Wno-error=switch-enum
build --per_file_copt=external/.*json_schema_validator.*@-Wno-error=range-loop-construct
build --host_per_file_copt=external/.*json_schema_validator.*@-Wno-error=range-loop-construct
build --per_file_copt=external/.*googletest.*@-Wno-error=switch-enum
build --host_per_file_copt=external/.*googletest.*@-Wno-error=switch-enum
build --per_file_copt=external/.*google_benchmark.*@-Wno-error=switch-enum
build --host_per_file_copt=external/.*google_benchmark.*@-Wno-error=switch-enum
build --per_file_copt=external/.*flatbuffers.*@-Wno-error=switch-enum
build --host_per_file_copt=external/.*flatbuffers.*@-Wno-error=switch-enum

# Places with warnings that we need to fix
build --per_file_copt=score/mw/com/impl/bindings/lola/slot_decrementer.*@-Wno-error=self-move
build --per_file_copt=score/mw/com/impl/bindings/lola/messaging/message_passing_service_instance_methods_test.*@-Wno-error=unused-but-set-variable
build --per_file_copt=score/mw/com/impl/skeleton_base_test.*@-Wno-error=self-move

common:linux_x86_64_score_gcc_12_2_0_posix --platforms=@score_bazel_platforms//:x86_64-linux-gcc_12.2.0-posix
common:linux_x86_64_score_gcc_12_2_0_posix --extra_toolchains=@score_gcc_x86_64_toolchain//:x86_64-linux
common:linux_aarch64_score_gcc_12_2_0_posix --platforms=@score_bazel_platforms//:aarch64-linux-gcc_12.2.0-posix
Expand Down
3 changes: 3 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ gcc_toolchains.toolchain(
name = "gcc_toolchain_x86_64",
extra_cxxflags = [
"-fdiagnostics-color=always", # Adds copt to always use coloring in build output
"-Wswitch-enum",
"-Werror",
"-Wno-error=deprecated-declarations",
],
extra_ldflags = [
"-lstdc++",
Expand Down
1 change: 1 addition & 0 deletions score/mw/com/impl/bindings/lola/subscription_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ SubscriptionState SubscriptionStateMachineStateToSubscriptionState(SubscriptionS
return SubscriptionState::kSubscribed;
case SubscriptionStateMachineState::SUBSCRIPTION_PENDING_STATE:
return SubscriptionState::kSubscriptionPending;
case SubscriptionStateMachineState::STATE_COUNT:
default:
SCORE_LANGUAGE_FUTURECPP_ASSERT_PRD_MESSAGE(false, "Invalid subscription state");
}
Expand Down
Loading