-
Notifications
You must be signed in to change notification settings - Fork 24
Add valid only allowed to link to valid check #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexanderLanin
merged 5 commits into
eclipse-score:main
from
MaximilianSoerenPollak:MSP_add_valid_check
May 19, 2026
+62
β0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4e20739
Feat: Add check to ensure valid is linked to valid
MaximilianSoerenPollak 82adeb0
Chore: Formatting & Linting
MaximilianSoerenPollak 7146d9d
Fix: Address performance concerns and other PR comments
MaximilianSoerenPollak 2f44318
Chore: Formatting
MaximilianSoerenPollak a98fce9
Update warning message
MaximilianSoerenPollak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
src/extensions/score_metamodel/tests/rst/graph/test_invalid_graph.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| .. | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| #CHECK: check_valid_only_links_to_valid | ||
|
|
||
| .. feat_req:: Parent requirement INVALID QM | ||
| :id: feat_req__parent__QM_invalid | ||
| :safety: QM | ||
| :status: invalid | ||
|
|
||
| .. We can not yet enable this test. As the check is only an 'info' and not yet a true warning | ||
| .. Therefore the test is the inverse of what we will test once it is enabled. | ||
|
|
||
| .. #EXPECT: comp_saf_fmea__child__16: is valid but links to invalid need(s): | ||
| #EXPECT-NOT: invalid need(s): | ||
|
|
||
| .. comp_saf_fmea:: Child requirement | ||
| :id: comp_saf_fmea__child__1 | ||
| :safety: QM | ||
| :status: valid | ||
| :mitigated_by: feat_req__parent__QM_invalid |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why filter out externals? Doesn't that mean it is ok to link invalid external needs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the check, what we want to do is we want to check that any LOCAL needs do not link to any invalid needs (local or external).
This way we will not check that external ones link badly.