Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
73fd84e
Provide new configuration interfaces
NicolasFussberger Apr 24, 2026
164b832
Upgrade baselibs & flatbuffer version
NicolasFussberger May 18, 2026
2325ae7
Use baselibs flatbuffer helper
NicolasFussberger May 18, 2026
5090054
Config refactoring
NicolasFussberger May 19, 2026
d73fa63
Use bazel rule to generate fb file
NicolasFussberger May 19, 2026
dcaa534
Extend documentation
NicolasFussberger May 19, 2026
5203bbc
Narrow RecoveryAction options
NicolasFussberger May 19, 2026
c9367b1
Remove optional from required fields
NicolasFussberger May 19, 2026
fb24424
Remove unrelated test output
NicolasFussberger May 19, 2026
b5f777f
Run formater on new code
NicolasFussberger May 19, 2026
eb8a044
Change method names to CamelCase
NicolasFussberger May 21, 2026
d523966
Move accessor method impl to cpp file
NicolasFussberger May 21, 2026
24d6e5f
Add #endif comments
NicolasFussberger May 21, 2026
f70d64b
ConfigBuilder is no longer a nested class
NicolasFussberger May 21, 2026
99cdb9c
Add assertions for required fields
NicolasFussberger May 21, 2026
a1f2860
Add assertion for sub-ms precision
NicolasFussberger May 21, 2026
89b2eb7
Merge branch 'main' into feature/load-new-lifecycle-config
paulquiring May 21, 2026
efe69a0
Use uid_t and gid_t types
NicolasFussberger May 22, 2026
5c25b13
Implement Environment var classes
NicolasFussberger May 22, 2026
dbfa690
Scheduling policy as int
NicolasFussberger May 22, 2026
a6e2b08
Refactor handling of mandatory and optional values
NicolasFussberger May 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ bazel_dep(name = "rules_oci", version = "2.3.0")
bazel_dep(name = "aspect_rules_lint", version = "2.0.0")
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "flatbuffers", version = "25.9.23")
bazel_dep(name = "flatbuffers", version = "25.12.19")
bazel_dep(name = "download_utils", version = "1.2.2")
bazel_dep(name = "googletest", version = "1.17.0.bcr.2")

Expand Down Expand Up @@ -134,6 +134,13 @@ use_repo(oci, "debian-test-runtime", "debian-test-runtime_linux_amd64")
bazel_dep(name = "score_baselibs_rust", version = "0.1.2")
bazel_dep(name = "score_baselibs", version = "0.2.6")

# Temporarily overwrite baselibs to use the new flatbuffer config loader until there is a new release
git_override(
module_name = "score_baselibs",
commit = "498a4b256c9073602140243d30c33b106e279f75",
remote = "https://github.com/eclipse-score/baselibs.git",
)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulquiring Any idea when a new baselibs release will be available containing the new flatbuffer functionality?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# Hedron's Compile Commands Extractor for Bazel
# https://github.com/hedronvision/bazel-compile-commands-extractor
bazel_dep(name = "hedron_compile_commands", dev_dependency = True)
Expand Down
50 changes: 10 additions & 40 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

77 changes: 77 additions & 0 deletions src/launch_manager_daemon/config/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,84 @@
#
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

load("@score_baselibs//score/flatbuffers/bazel:codegen.bzl", "generate_cpp")

exports_files([
"lm_flatcfg.fbs",
"lm_flatcfg_generated.h",
])

filegroup(
name = "new_lm_flatcfg_fbs",
srcs = ["src/new_lm_flatcfg.fbs"],
visibility = ["//visibility:public"],
)

generate_cpp(
name = "new_lm_flatcfg_generated",
output = "new_lm_flatcfg_generated.h",
schema = "src/new_lm_flatcfg.fbs",
)

cc_library(
name = "config",
srcs = ["src/config.cpp"],
hdrs = ["include/config.hpp"],
includes = ["include"],
visibility = ["//src:__subpackages__"],
)

cc_library(
name = "config_loader",
hdrs = ["include/config_loader.hpp"],
includes = ["include"],
visibility = ["//src:__subpackages__"],
deps = [
":config",
"@score_baselibs//score/filesystem",
"@score_baselibs//score/result",
],
)

cc_library(
name = "flatbuffer_config_loader",
srcs = [
"src/flatbuffer_config_loader.cpp",
":new_lm_flatcfg_generated",
],
hdrs = ["include/flatbuffer_config_loader.hpp"],
includes = [
".",
"include",
"src",
],
visibility = ["//src:__subpackages__"],
deps = [
":config_loader",
"//src/launch_manager_daemon/common:log",
"@flatbuffers",
"@score_baselibs//score/flatbuffers:flatbufferutils",
],
)

cc_test(
name = "config_UT",
srcs = ["src/config_UT.cpp"],
visibility = ["//tests:__subpackages__"],
deps = [
":config",
"@googletest//:gtest_main",
],
)

cc_test(
name = "flatbuffer_config_loader_UT",
srcs = ["src/flatbuffer_config_loader_UT.cpp"],
visibility = ["//tests:__subpackages__"],
deps = [
":flatbuffer_config_loader",
"@flatbuffers",
"@googletest//:gtest_main",
],
)
Loading
Loading