remove module folder template#683
Conversation
RolandJentschETAS
requested review from
PandaeDo,
aschemmel-tech,
masc2023 and
pahmann
as code owners
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
@RolandJentschETAS , Feature Architecture is now also part of module folder, why not deleted or any other artefact in the Feature Template Folder, which is in Module?
|
The created documentation from the pull request is available at: docu-html |
There is a difference in this content. Whats currently in the feature template folder is more a template for a "new feature crq". This is mostly discussed in a PR in the score main. So the content is not the same as in the feature template. Maybe we have to split this somehow. Or at least clarify first. Then I can also remove this. |
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
Can you remove also this template, currently not properly moved to folder template
https://eclipse-score.github.io/process_description/pr-683/process_areas/security_analysis/guidance/security_analysis_checklist.html#, compare safety analysis, but I see at least one case, that you have not the latest templates in the module folder
https://eclipse-score.github.io/process_description//main/folder_templates/modules/module_name/docs/safety_mgt/module_safety_analysis_fdr.html#doc__module_safety_analysis_fdr
but in your PR it links to
https://eclipse-score.github.io/module_template/main/docs/safety_mgt/module_safety_analysis_fdr.html
|
|
||
| - :need:`doc__platform_safety_analysis_fdr` (platform) | ||
| - :need:`doc__module_safety_analysis_fdr` (module) | ||
| - `Safety Analysis Formal Review Checklist <https://eclipse-score.github.io/module_template/main/docs/safety_mgt/module_safety_analysis_fdr.html>`__ (module) |
There was a problem hiding this comment.
Why choosing a different title as in the document header? Safety Analysis checklist?
There was a problem hiding this comment.
Ok, see general comment, the current checklist is
but different as in you PR, as the module_template folder is not up-to-date, so may you need first to update module_template folder before removing it?
2 participants
Remove module folder template in the process description, because they are now in the module template.