Skip to content

locking: enforce Bzlmod lockfile consistency #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalavrezo-qorix merged 4 commits into from
Mar 5, 2026
Merged

locking: enforce Bzlmod lockfile consistency #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
429d096
locking: enforce Bzlmod lockfile consistency
dcalavrezo-qorix Mar 3, 2026
78b410e
lock: update lockfile
dcalavrezo-qorix Mar 3, 2026
f015112
fix: formatting fix
dcalavrezo-qorix Mar 3, 2026
54f90df
revert: don't use the lockfile_mode in scripts
dcalavrezo-qorix Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_autosd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
sudo apt-get install -y podman curl qemu-system createrepo-c
- name: Build Showcases
run: |
bazel build --config autosd-x86_64 //images/autosd_x86_64:score-showcases
bazel build --lockfile_mode=error --config autosd-x86_64 //images/autosd_x86_64:score-showcases
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--lockfile_mode is a Bazel startup/global option and should be placed before the command name. As written (bazel build --lockfile_mode=error ...) Bazel may not apply lockfile enforcement; prefer bazel --lockfile_mode=error build ....

Suggested change
bazel build --lockfile_mode=error --config autosd-x86_64 //images/autosd_x86_64:score-showcases
bazel --lockfile_mode=error build --config autosd-x86_64 //images/autosd_x86_64:score-showcases

Copilot uses AI. Check for mistakes.
- name: Copy showcases folder
run: |
set -e
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test_ebclfsa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
cache-save: ${{ github.event_name == 'push' }}
- name: Build for EB corbos Linux for Safety Applications and run tests
run: |
bazel build --config=eb-aarch64 //images/ebclfsa_aarch64/scrample_integration:run
bazel build --lockfile_mode=error --config=eb-aarch64 //images/ebclfsa_aarch64/scrample_integration:run
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--lockfile_mode is a Bazel startup/global option and should be passed before the command. Update this to bazel --lockfile_mode=error build ... to ensure CI fails on lockfile drift as intended.

Suggested change
bazel build --lockfile_mode=error --config=eb-aarch64 //images/ebclfsa_aarch64/scrample_integration:run
bazel --lockfile_mode=error build --config=eb-aarch64 //images/ebclfsa_aarch64/scrample_integration:run

Copilot uses AI. Check for mistakes.
- name: Upload test logs
uses: actions/upload-artifact@v5
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build_and_test_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
cache-save: ${{ github.event_name == 'push' }}
- name: Build image
run: |
bazel build --config=linux-x86_64 //images/linux_x86_64:image
bazel build --lockfile_mode=error --config=linux-x86_64 //images/linux_x86_64:image
- name: Integration tests
run: |
bazel test --config=linux-x86_64 //feature_integration_tests/itf:linux_x86_64
bazel test --lockfile_mode=error --config=linux-x86_64 //feature_integration_tests/itf:linux_x86_64
Comment thread
dcalavrezo-qorix marked this conversation as resolved.
4 changes: 2 additions & 2 deletions .github/workflows/build_and_test_qnx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ jobs:
SCORE_QNX_USER: ${{ secrets.SCORE_QNX_USER }}
SCORE_QNX_PASSWORD: ${{ secrets.SCORE_QNX_PASSWORD }}
run: |
bazel build --config qnx-x86_64 //images/qnx_x86_64:image
bazel build --lockfile_mode=error --config qnx-x86_64 //images/qnx_x86_64:image
- name: Run integration tests
run: |
bazel test --config=itf-qnx-x86_64 //feature_integration_tests/itf:qnx_x86_64
bazel test --lockfile_mode=error --config=itf-qnx-x86_64 //feature_integration_tests/itf:qnx_x86_64
Comment on lines +73 to +76
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--lockfile_mode is a Bazel startup/global option and should come before the command name. Please reorder these invocations to bazel --lockfile_mode=error build ... and bazel --lockfile_mode=error test ... so the lockfile enforcement is actually applied.

Copilot uses AI. Check for mistakes.
- name: Cleanup QNX license
if: always()
run: sudo rm -rf /opt/score_qnx
26 changes: 26 additions & 0 deletions .github/workflows/bzlmod-lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# *******************************************************************************
# Copyright (c) 2025 Contributors to the Eclipse Foundation
#
# See the NOTICE file(s) distributed with this work for additional
# information regarding copyright ownership.
#
# This program and the accompanying materials are made available under the
# terms of the Apache License Version 2.0 which is available at
# https://www.apache.org/licenses/LICENSE-2.0
#
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************
name: Bzlmod Lockfile Check
on:
pull_request:
types: [opened, reopened, synchronize]
merge_group:
types: [checks_requested]
push:
branches:
- main
jobs:
bzlmod-lock:
uses: eclipse-score/cicd-workflows/.github/workflows/bzlmod-lock-check.yml@main
with:
working-directory: .
3 changes: 2 additions & 1 deletion .github/workflows/test_and_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
run: |
mkdir -p artifacts
find bazel-testlogs/external -name 'test.xml' -print0 | xargs -0 -I{} cp --parents {} artifacts/
cp -r "$(bazel info bazel-bin)/coverage/rust-tests" artifacts/rust
cp -r "$(bazel info --lockfile_mode=error bazel-bin)/coverage/rust-tests" artifacts/rust
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel info --lockfile_mode=error bazel-bin places a startup/global option after the command. To ensure Bazel actually enforces the lockfile mode, pass it before info (e.g., bazel --lockfile_mode=error info bazel-bin).

Suggested change
cp -r "$(bazel info --lockfile_mode=error bazel-bin)/coverage/rust-tests" artifacts/rust
cp -r "$(bazel --lockfile_mode=error info bazel-bin)/coverage/rust-tests" artifacts/rust

Copilot uses AI. Check for mistakes.
zip -r ${{ github.event.repository.name }}_test_reports.zip artifacts/
shell: bash
- name: Upload release asset (attach ZIP to GitHub Release)
Expand All @@ -103,6 +103,7 @@ jobs:
- name: Build documentation
run: |
bazel --output_base="/home/runner/.cache/bazel/output_base" run \
--lockfile_mode=error \
--repo_contents_cache="/home/runner/.cache/bazel/repo_contents" \
--repository_cache="/home/runner/.cache/bazel/repo" \
--disk_cache="/home/runner/.cache/bazel/disk" \
Comment thread
dcalavrezo-qorix marked this conversation as resolved.
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Bazel
bazel-*
MODULE.bazel.lock
user.bazelrc

_logs
Expand Down
8,470 changes: 8,470 additions & 0 deletions MODULE.bazel.lock
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion bazel_common/score_python.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ python.toolchain(
is_default = True,
python_version = PYTHON_VERSION,
)
Comment thread
dcalavrezo-qorix marked this conversation as resolved.
use_repo(python)

pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip", dev_dependency = True)
pip.parse(
Expand Down
Loading