Add centralized clang-tidy infrastructure#2
Open
RSingh1511 wants to merge 3 commits into
Open
Conversation
RSingh1511
force-pushed
the
rs/clang_tidy
branch
3 times, most recently
from
209b4ce to
87b5b33
Compare
mobileinfo
suggested changes
Apr 10, 2026
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| name: Improvement | |||
| about: 'Issue to track a improvement' | |||
| ## Related ticket | ||
|
|
||
| > [!IMPORTANT] | ||
| > Please replace `[ISSUE-NUMBER]` with the issue-number that tracks this bug fix. If there is no such |
There was a problem hiding this comment.
tracks this bug fix -> this improvement
|
|
||
| # NOTE: WarningsAsErrors is yet subject to be expanded per module as compliance increases. | ||
| WarningsAsErrors: > | ||
| clang-analyzer-*, |
| --- | ||
| # Default clang-tidy configuration for S-CORE C++ modules. | ||
| # NOTE: the set of enabled checks is yet subject to be tailored per module. | ||
| Checks: > |
| @@ -0,0 +1,3 @@ | |||
| ASAN_OPTIONS=exitcode=55 allow_addr2line=1 verbosity=1 check_initialization_order=1 detect_stack_use_after_return=1 print_stats=1 halt_on_error=1 allocator_may_return_null=1 detect_leaks=1 suppressions=%ROOT%sanitizers/suppressions/asan.supp | |||
There was a problem hiding this comment.
do we also have to add "ubsan.supp" and "lsan.supp" in the template?
| @@ -0,0 +1 @@ | |||
| 8.3.0 | |||
There was a problem hiding this comment.
why specify bazelversion in tests folder?
There was a problem hiding this comment.
it's better to add separat readme file in each tool, i.e clang_tidy/readme.md, sanitizers/readme.md etc.
the readme file in root only summarizes all tools in this repo.
RSingh1511
force-pushed
the
rs/clang_tidy
branch
5 times, most recently
from
0e3d62d to
d584adc
Compare
…ession, remove dead clang_tidy.bazelrc, improve HeaderFilterRegex and docs
RSingh1511
requested review from
4og,
FScholPer,
antonkri,
mobileinfo and
pawelrutkaq
rmaddikery
reviewed
May 15, 2026
| @@ -1,3 +1,3 @@ | |||
| ASAN_OPTIONS=allocator_may_return_null=1 allow_addr2line=1 check_initialization_order=1 detect_leaks=1 detect_stack_use_after_return=1 exitcode=55 halt_on_error=1 print_stats=1 strict_string_checks=1 verbosity=1 suppressions=%ROOT%sanitizers/suppressions/asan.supp | |||
There was a problem hiding this comment.
could you please seperate the tsan, ubsn and lsan changes to a seperate PR?
rmaddikery
reviewed
May 15, 2026
rmaddikery
left a comment
rmaddikery
left a comment
There was a problem hiding this comment.
Would be ideal to see ONLY the changes related to Adding centralized clang-tidy infrastructure and not sanitizers.
4og
requested changes
May 15, 2026
| module(name = "score_cpp_policies") | ||
| module( | ||
| name = "score_cpp_policies", | ||
| version = "0.0.0", |
Member
There was a problem hiding this comment.
The version = "0.0.0", is not really needed
| bazel_dep(name = "rules_go", version = "0.60.0", repo_name = "io_bazel_rules_go") | ||
|
|
||
| bazel_dep(name = "score_cpp_policies") | ||
| bazel_dep(name = "score_cpp_policies", version = "0.0.0") |
Member
There was a problem hiding this comment.
The , version = "0.0.0" is not needed here either
| bazel_dep(name = "toolchains_llvm", version = "1.7.0") | ||
| bazel_dep(name = "rules_cc", version = "0.2.17") | ||
|
|
||
| bazel_dep(name = "rules_go", version = "0.60.0", repo_name = "io_bazel_rules_go") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds centralized clang-tidy support to `score_cpp_policies`.