Use receiver-style zenoh-flat-jni bindings by milyin · Pull Request #481 · eclipse-zenoh/zenoh-java

milyin · 2026-07-15T15:09:17Z

Summary

call generated receiver methods instead of package functions that repeated their handle argument
use Config.insertJson5, Publisher.put/delete, Querier.get, Query.reply*, and Session operations directly
open the native session through the generated Session.open companion factory
preserve Rust ownership by cloning Config before open and KeyExpr before consuming declarations
retain the regression test that opens multiple sessions from one Config
update CI to the linked zenoh-flat-jni commit while resolving prebindgen from GitHub main

Throughput

Release benchmark, subscriber median msg/s across three passes, 8 rounds × 100,000 messages per point:

Payload	upstream main	flat JNI	change
8 B	485,085	869,716	+79.3%
64 B	461,949	847,465	+83.5%
1 KiB	407,366	657,009	+61.3%
8 KiB	223,830	249,825	+11.6%

Baseline: upstream 20622e3. Benchmarked implementation: 834a51c. The later receiver-method update relocates the same generated wrapper bodies and native calls; it does not add work to the hot path.

Validation

Validated locally against prebindgen 616f676 and zenoh-flat-jni d8613fb:

composite Kotlin/JNI compilation
full 101-test native JVM suite
linked JNI Cargo check, clippy, and tests

Depends on:

CI intentionally resolves prebindgen from GitHub main, so the dependency chain must merge in order. This is the coordinated successor to #473.

BFS from each required-but-unresolved type through struct fields, enum variants, generic args, and impl Fn args, surfacing transitively unresolved entries that propagate_required cannot reach (because subs edges don't exist past an unresolved parent). Without this, a missing declaration in build.rs for a type only referenced as a field of another unresolved struct went unreported. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

.method() is a namespace declaration — every #[prebindgen] fn must be assigned to a typed handle, data class, enum, or kotlin_package. There is no third "orphan" bucket, so JNIOrphaned was always emitted empty and the duplicate declared_function_names helper just repeated the PrebindgenExt::declared_functions trait method. - delete write_jni_orphaned, jni_orphaned_class_name, the stale generated JNIOrphaned.kt file - rename render_jni_orphaned_source -> render_jni_package_source, drop the now-redundant include_only_promoted / wrap_in_object / declared / class_name params - drop declared_function_names; render_jni_native_source now takes &HashSet<syn::Ident> from declared_functions() directly Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Replace the five scattered self.qualify_emitted_type() calls (build_input_fn, build_output_fn, opaque_handle_input, build_handle_destructor_items, option_input) with a single AST visitor pass applied once at write time. The previous design qualified only at specific emit sites — each new emit site had to remember the call. emit_into_dispatcher missed it, so the impl-Into dispatcher body emitted bare KeyExpr/ZKeyExpr references that failed to resolve in the binding crate's scope. Architecture: - New PrebindgenExt::post_process_item(item: &mut syn::Item) trait hook (default no-op), invoked by write_rust on every emitted item. - JniExt implements it via qualify_item, which runs QualifyEmittedTypes — a syn::visit_mut::VisitMut that walks the full AST (signatures, generic args, type ascriptions in let bindings, *mut/*const in cast expressions) and prefixes every bare single-segment Type::Path matching a registered source-module name with source_module. - option_input no longer takes &JniExt; the body uses the bare t1 token and the post-emit visitor qualifies it later. Also fixes the pre-existing TypeEntry field-name drift in final_invariant_reports_unresolved_field_of_unresolved_struct. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

…pendency - Remove :zenoh-flat-jni from gradle subprojects (moved to separate repo) - Replace local source dependency with Maven: org.eclipse.zenoh:zenoh-flat-jni:1.9.0 - Remove Cargo build orchestration (buildZenohFlatJni, buildZenohFlatJNI, BuildMode) - Remove build paths for zenoh-flat-jni libraries (now bundled in Maven JAR) - Remove Cargo-related Gradle plugins and tasks - Native libraries are now obtained from the zenoh-flat-jni Maven artifact - Kotlin sources are now imported from the Maven JAR as a dependency - Supports optional local development via: includeBuild("../zenoh-flat-jni") - Simplifies zenoh-java build: Gradle now only compiles Kotlin, not Rust Migration notes: - zenoh-flat-jni is now at https://github.com/ZettaScaleLabs/zenoh-flat-jni - Versions will be synchronized with Zenoh releases (1.9.0, etc.) - For local development, clone both repos and use composite builds if needed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ment - Uncomment includeBuild for ../zenoh-flat-jni since it's now in the PREBINDGEN workspace - zenoh-flat-jni is at /Users/milyin/PREBINDGEN/zenoh-flat-jni - Gradle will prefer local build over Maven artifact when composite build is enabled - Allows coordinated development of zenoh-java and zenoh-flat-jni Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The zenoh-flat-jni project has been moved to: - GitHub: https://github.com/ZettaScaleLabs/zenoh-flat-jni - Local workspace: /Users/milyin/PREBINDGEN/zenoh-flat-jni zenoh-java now consumes zenoh-flat-jni via: 1. Maven artifact (org.eclipse.zenoh:zenoh-flat-jni:1.9.0) in production 2. Gradle composite build (../zenoh-flat-jni) for local development Removing the local copy avoids duplication and confusion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

milyin · 2026-07-15T15:09:34Z

Linked generator inputs: ZettaScaleLabs/zenoh-flat#1 and ZettaScaleLabs/zenoh-flat-jni#2.

# Conflicts: # zenoh-jni/Cargo.lock

zenoh-flat's consolidated API dropped the Z prefix from its Rust types (ZSample -> Sample, ...), and the generated callback interface names follow the type name mechanically: ZSampleCallback -> SampleCallback etc. Rename the four callback references in FlatCallbacks.kt (signatures are unchanged) and follow the encoding id accessor rename (id -> getId). Pin CI to the updated zenoh-flat-jni (receiver-style bindings regenerated against prebindgen main and zenoh-flat main) and to zenoh-flat main. Verified locally: jvmTest 101 tests, 0 failures against the composite build.

milyin · 2026-07-16T10:00:44Z

Updated to the consolidated upstream stack (commit 8461c29):

Callback names track the de-prefixed zenoh-flat types: ZSampleCallback→SampleCallback, ZQueryCallback→QueryCallback, ZReplyCallback→ReplyCallback, ZHelloCallback→HelloCallback in FlatCallbacks.kt (signatures unchanged — the generated callback interface name follows the Rust type name, which lost its Z prefix in zenoh-flat's API consolidation). Also Encoding.id→getId.
CI pins moved off the prototype branches onto the mainline stack: zenoh-flat-jni → 7b307c9 (Modernize to current prebindgen: receiver-style API, derived names, split overloads ZettaScaleLabs/zenoh-flat-jni#3 — the receiver-style bindings regenerated against prebindgen main), zenoh-flat → 7b151d7 (main, the consolidated flat API).

Validation: composite build compiles; jvmTest 101 tests, 0 failures locally against prebindgen main + zenoh-flat main + zenoh-flat-jni PR #3.

zenoh-flat-jni now derives all regular method names from the flat crate's identifiers (explicit .name() only where a clash forces it), so the internal calls follow: JniKeyExpr.newTryFrom/newAutocanonize/newJoin/newConcat, JniConfig.newFrom*, JniEncoding.newFromString/newWithSchema, JniZBytes.newFromVec, zSession.getPeersZid/getRoutersZid. SDK public API unchanged. CI pin bumped to the matching zenoh-flat-jni commit.

milyin · 2026-07-16T11:27:33Z

Retargeted to the zenoh-flat-transition integration branch — this PR is now the first constituent of the umbrella transition PR #482, which accumulates all zenoh-flat–related work and merges to main as a whole.

milyin and others added 30 commits May 23, 2026 17:13

initial code generation

57304da

templates in separate files in prebindgen-ext

c4b5aee

mangle harness

b69f61b

dependency on zenoh-flat-jni added

4415c8d

switch to keyexprValidate, package support

3631ce3

zenoh-jni reexported by zenoh-flat-jni

45d6c82

No load generator

9e09d5a

Merge branch 'main' into zenoh-flat-jni

b0ec4f3

output only declared in prebindgen-ext

d1dae5a

better error reporting

417f8a8

reporting fix

51b3c1f

refactored, test added

7d3a449

ptr class added

79d6ccf

qualify non-fqn types

caacadb

filter undeclared fns out of JNINative/JNIOrphaned emit

804e49f

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

missing functions added to autogeneration

9cd677a

into in build.rs

f3b6ee5

transition to zenoh-flat keyexpr for zenoh-java

045771c

ZKeyExpr improved

e78bcda

closeable data classes

c348133

universa close for data classes

2ead434

throwable data class

31fbe85

config in zenoh-flat

bb56ce0

scouting api

5d57dfa

JNIScout removed

2b64a24

whatami from jni

2ebdf6a

value type

975f3f8

milyin and others added 10 commits June 13, 2026 16:37

unfold encoding for acceleration

660973f

renamings in builder

1d27ecb

api change ported

d742ed4

serialize fixes

aa7d490

loading in zenoh-flat-jni

f164b94

import predefined encodings as consts

7e6157a

Use typed zenoh-flat-jni key expression overloads

97363ec

This was referenced Jul 15, 2026

Expose opaque-tier fields needed by generated JNI ZettaScaleLabs/zenoh-flat#1

Merged

Generate receiver methods from the original zenoh-flat API ZettaScaleLabs/zenoh-flat-jni#2

Closed

milyin added 6 commits July 15, 2026 17:13

Install CI lint components for the pinned Rust toolchain

213f8c9

Run flat JNI clippy without a tracked lockfile

1de085d

Merge remote-tracking branch 'origin/main' into prebindgen-split-api

1ee4c25

# Conflicts: # zenoh-jni/Cargo.lock

Preserve consuming Rust API semantics

834a51c

Limit rustfmt CI to the JNI crate

03fa790

Remove stale local task lock

434db4d

milyin mentioned this pull request Jul 15, 2026

Make JniGen name mangling placement-aware milyin/prebindgen#79

Merged

milyin added 2 commits July 15, 2026 18:51

Use generated JNI receiver methods

7c7d2c4

Pin receiver-style JNI bindings in CI

d507066

milyin changed the title ~~Use typed zenoh-flat-jni KeyExpr overloads~~ Use receiver-style zenoh-flat-jni bindings Jul 15, 2026

milyin mentioned this pull request Jul 16, 2026

zenoh-flat transition (integration branch) #482

Draft

2 tasks

milyin changed the base branch from main to zenoh-flat-transition July 16, 2026 11:27

milyin merged commit 94c885a into zenoh-flat-transition Jul 16, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use receiver-style zenoh-flat-jni bindings#481

Use receiver-style zenoh-flat-jni bindings#481
milyin merged 141 commits into
zenoh-flat-transitionfrom
prebindgen-split-api

milyin commented Jul 15, 2026 •

edited

Loading

Uh oh!

milyin commented Jul 15, 2026

Uh oh!

milyin commented Jul 16, 2026

Uh oh!

milyin commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

milyin commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Throughput

Validation

Uh oh!

milyin commented Jul 15, 2026

Uh oh!

milyin commented Jul 16, 2026

Uh oh!

milyin commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

milyin commented Jul 15, 2026 •

edited

Loading