WIP: small but crucial fixes to ecbuild

[mcocdawc]

Description

Change the detection that avoids redundant project creation.
The current setup prevented a test-only build.

Change macro to function, that has equivalent behaviour, but less pollution.

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

[Copilot]

Pull request overview

This PR adjusts ecbuild’s generated CMake package config behavior to avoid incorrectly skipping target imports in some find_package() scenarios, and reduces CMake variable-scope pollution by converting a helper macro into a function.

Changes:

• Refine the guard in project-config.cmake.in so install-tree exports always load the *-targets.cmake file, while build-tree exports can skip it when appropriate.
• Convert ecbuild_target_fortran_module_directory from a macro() to a function() to avoid leaking internal variables into the caller’s scope.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
cmake/project-config.cmake.in	Updates the logic that decides whether to include the exported targets file when a package config is loaded.
cmake/ecbuild_target_fortran_module_directory.cmake	Converts a macro to a function to limit variable pollution while keeping behavior equivalent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new guard/comment says we only skip loading targets when we are “genuinely inside” the exporting build (i.e. not an unrelated project with the same name). However the condition only checks @PROJECT_NAME@_IS_BUILD_DIR_EXPORT and that @PROJECT_NAME@_BINARY_DIR is non-empty; any unrelated project named @PROJECT_NAME@ will also define @PROJECT_NAME@_BINARY_DIR, so for build-tree exports this would still skip loading the targets file. Consider either (a) tightening the condition to verify @PROJECT_NAME@_BINARY_DIR actually matches this export’s build tree (e.g., compare against @PROJECT_NAME@_BASE_DIR / PACKAGE_PREFIX_DIR), or (b) adjusting the comment to match the actual behavior.

Suggested change

	# always load the targets file. For build-tree exports the targets are already
	# defined by the build system, so we only skip when we are genuinely inside that
	# build (i.e. the variable was set by ecbuild's own project() hook, not by an
	# unrelated project that happens to share the same name).
	if(NOT (@PROJECT_NAME@_IS_BUILD_DIR_EXPORT AND @PROJECT_NAME@_BINARY_DIR))
	# always load the targets file. For build-tree exports the targets are already
	# defined by the build system, so we only skip when we are genuinely inside that
	# build tree, i.e. when ecbuild's own project() hook has set
	# @PROJECT_NAME@_BINARY_DIR to the same location as this export's base directory.
	set(_@PROJECT_NAME@_INSIDE_EXPORTING_BUILD FALSE)
	if(@PROJECT_NAME@_IS_BUILD_DIR_EXPORT AND DEFINED @PROJECT_NAME@_BINARY_DIR AND NOT "@PROJECT_NAME@_BINARY_DIR" STREQUAL "")
	get_filename_component(_@PROJECT_NAME@_EXPORT_BASE_DIR "${@PROJECT_NAME@_BASE_DIR}" REALPATH)
	get_filename_component(_@PROJECT_NAME@_CURRENT_BINARY_DIR "${@PROJECT_NAME@_BINARY_DIR}" REALPATH)
	if(_@PROJECT_NAME@_EXPORT_BASE_DIR STREQUAL _@PROJECT_NAME@_CURRENT_BINARY_DIR)
	set(_@PROJECT_NAME@_INSIDE_EXPORTING_BUILD TRUE)
	endif()
	endif()
	if(NOT _@PROJECT_NAME@_INSIDE_EXPORTING_BUILD)