Release 5.17.0#339
Draft
marcosbento wants to merge 87 commits into
Draft
Conversation
This allows the use of these constants by the inline functions defined below.
Re ECFLOW-2075
- Remove unnecessary Std/Boost dependencies - Improve documentation and set of test cases
For unclear reasons replaceall is an alias to replace_all function, and thus unnecessary. These changes replace replaceall with the more aptly named replace_all, and completely remove replaceall. Also, adds documentation and makes use of clear names for the parameters. Re ECFLOW-2076
Also, add documentation and tests to cover the functionality. Re ECFLOW-2076
Re ECFLOW-2077
Re ECFLOW-2076
Add documentation to all functions, and increase the functional tests. This effectively removes all uses of boost/algorithm/string. Re ECFLOW-2076
Re ECFLOW-2076
Re ECFLOW-2079
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
A dict/kwargs key is guaranteed to be string by construction, so it is unnecessary to attempt extraction with error handling. Direct casting the object can be used instead. Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Re ECFLOW-2090
Move the Process handling capabilities and the Provisioning of test artifacts (test files, directories, environment variables) into a single ecflow/test/scaffold support library.
The additional tests ensure the correct handling the CLI options, along with the environment variables that can also be used to configure the ecflow_udp server.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 49.68% 50.56% +0.88%
==========================================
Files 1237 1237
Lines 97636 98653 +1017
Branches 14829 14958 +129
==========================================
+ Hits 48507 49883 +1376
+ Misses 49129 48770 -359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcosbento
force-pushed
the
release/5.17.0
branch
from
8e3dcf5 to
cce755a
Compare
The large amount of updated files is due to the migration from Boost.python to pybind11, but in practice there were no API changes.
marcosbento
force-pushed
the
release/5.17.0
branch
from
cce755a to
c238a28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per PR title
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-339