Repository navigation
Ayobami h canvas playback toggle - #32
Merged
Merged
Conversation
feat: toggle playback from preview canvas
PR #26 was authored against the DOM PreviewCanvas renderer and merged after the WebGL-only consolidation deleted it, leaving App.tsx importing a missing module (build broke on TS2307) and wrapping the toggle surface around the retired renderer instead of WebGLScene. - App: drop the dead PreviewCanvas import; wrap PreviewPlaybackSurface around the live WebGLScene + BrandOverlay. - e2e/app: pausePreview now pauses idempotently via the "Preview playback" button's aria-pressed — clicking the surface now toggles playback, so the old focus-nudge click would have un-paused instead. - e2e/playback: add a test asserting a surface click freezes/resumes the real clock (not just aria-pressed); extend the R-restart poll timeout so the starved-clock case under full-suite parallelism isn't flaky. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue
Closes #
Type of change
How has this been tested?
Screenshots
Checklist
mainbranch