Repository navigation
Conversation
|
@AyobamiH is attempting to deploy a commit to the Jaoude Studios Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
GitHub checks are green on d982607. The only remaining blocker is Vercel team authorisation for Jaoude Studios. Could a team member authorise the deployment and rerun the check? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the editor usable on small mobile screens while preserving the existing desktop three-column layout.
This keeps the change focused on Issue #18:
Code / Preview / Styleworkspace switcherRelated issue
Closes #18
Type of change
How has this been tested?
Final validated head:
d982607b708b43bb1facc7f8d9a33a0add07e3e0.The final head passed the full CI suite both in my fork and upstream, including Playwright, lint, unit tests and typecheck/build.
An earlier upstream CI run exposed a Playwright/WebGL starvation issue in
projects.spec.ts. I reproduced the same failure against the exact upstreammaintree before modifying the test harness, confirming that the responsive feature was not required to reproduce it.The resulting test-only stabilisation centralises preview pausing in
e2e/app.tsand uses it from the project-persistence and responsive tests. It pauses the animated WebGL preview during unrelated interactions, including when the Preview workspace is visually hidden on mobile. No application behaviour is changed by these test-only changes.Local verification included:
The responsive Playwright coverage verifies:
Manual checks also covered playback interaction, timeline scrubbing, Projects, Save/Export reachability, Code editing, Style changes, state retention and returning to Preview.
Video evidence
320px: Preview, primary controls and horizontal overflow
Shows the preview remaining usable at 320px, playback controls fitting without horizontal scrolling, and the primary Projects, Save and Export controls remaining reachable.
codereel-issue-18-320px-preview-controls.webm
320px: Code / Preview / Style switching and state preservation
Shows the mobile workspace switcher moving between Code, Preview and Style while preserving editor state.
codereel-issue-18-320px-workspace-state.webm
375px: Preview, primary controls and horizontal overflow
Shows the same responsive behaviour at 375px with the preview and primary controls remaining usable without horizontal overflow.
codereel-issue-18-375px-preview-controls.webm
375px: Code / Preview / Style switching and state preservation
Shows Code, Preview and Style switching at 375px while retaining editor state.
codereel-issue-18-375px-workspace-state.webm
Desktop: Existing three-column editor preserved
Shows the existing desktop Code / Preview / Style three-column layout remaining intact at desktop width.
codereel-issue-18-desktop-three-column-preservation.webm
Screenshots
Video evidence above covers both mobile widths and desktop preservation.
Checklist
mainbranch