Skip to content

Recognize an attribute namespace only on an exact name match. [GH #305] - #306

Merged
daveedvdv-nvidia merged 1 commit into
edgcpp:mainfrom
mborland:0001
Oct 22, 2026
Merged

daveedvdv-nvidia merged 1 commit into
edgcpp:mainfrom
mborland:0001

Conversation

@mborland

@mborland mborland commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The PR enforces whole name matching against the known attribute namespaces

Closes: #305

@mborland mborland added the bug Something isn't working label Oct 15, 2026

@daveedvdv-nvidia daveedvdv-nvidia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comment/wording suggestions. Otherwise looks fine.

Comment thread src/attribute.c Outdated
Comment thread src/Changes Outdated
@edgcpp-bot

Copy link
Copy Markdown
Collaborator

AcknowlEDG review results updated for 51441e8dc8b4:

CI success.

@daveedvdv-nvidia
daveedvdv-nvidia merged commit bb28522 into edgcpp:main Oct 22, 2026
12 of 13 checks passed
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1d7c7d53-8272-4c3d-a11e-1a517d33b4dd
📥 Commits

Reviewing files that changed from the base of the PR and between 4047642 and bb28522.

📒 Files selected for processing: 7
  • src/attribute.c
  • src/pending_changes/gh-305-attribute-namespace-exact-match.txt
  • tests/tests/changes/.GH-ns-exact.rto/default.1.1.txt
  • tests/tests/changes/.GH-ns-exact.rto/default.1.matches.txt
  • tests/tests/changes/.GH-ns-exact.rto/edg_x86_32_cp.1.1.txt
  • tests/tests/changes/.GH-ns-exact.rto/edg_x86_64_cp.1.1.txt
  • tests/tests/changes/GH-ns-exact.sft.cpp
+----------------------------------------------------------------+
| First, solve the problem. Then, write the code. - John Johnson |
+----------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mborland
mborland deleted the 0001 branch October 22, 2026 20:11
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An attribute namespace that is only a prefix of a known one is accepted

3 participants