kuberesource: remove pod-role annotation from runtime#2510
Closed
burgerdev wants to merge 1 commit into
Closed
Conversation
sespiros
requested changes
Jul 8, 2026
sespiros
left a comment
sespiros
left a comment
Collaborator
There was a problem hiding this comment.
Thanks.
This will break
contrast/packages/cleanup-bare-metal.sh
Line 48 in de31291
We would either need to select node installers by matching on *-nodeinstaller pod-name pattern or give the installer a stable label.
davidweisse
reviewed
Jul 8, 2026
| WithLabels(map[string]string{"app.kubernetes.io/name": name}). | ||
| WithAnnotations(map[string]string{ | ||
| ContrastRoleLabelKey: string(manifest.RoleNodeInstaller), | ||
| "contrast.edgeless.systems/platform": platform.String(), |
Member
There was a problem hiding this comment.
Why do we have this? As far as I can see we don't use this anywhere as well.
Member
Author
Then ... I guess it's used after all and we can keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pod role is used in the manifest to apply special considerations to some pods (notably, Coordinators). Since the runtime is never a confidential pod, it does not make sense to annotate it with a pod role. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ are a more natural fit for this.