kuberesource: use common labeling strategy#2514
Conversation
sespiros
left a comment
There was a problem hiding this comment.
Thanks! Should we mark this as a breaking change, or at least add a note? Since an in place upgrade (albeit not a documented procedure) would not be possible since we are changing the label selectors on Contrast-managed resources?
ea6dabf to
a136090
Compare
There was a problem hiding this comment.
Should this also use kuberesource.SelectorLabels("kvstore", "coordinator")?
There was a problem hiding this comment.
Ok, it turns out that this selector is worth than useless, since we're already filtering by name and we don't set the label in RecoverConfigMaps. Removing it here, fixing RecoverConfigMaps in #2515.
b41e4ee to
5ac6f3e
Compare
It's marked as |
Co-authored-by: Spyros Seimenis <sespiros@users.noreply.github.com> Co-authored-by: davidweisse <98460960+davidweisse@users.noreply.github.com>
5ac6f3e to
7cbb310
Compare
This PR centralizes the definition of labels and label selectors, which used to be ad-hoc. As a result, labels for individual API resources may differ after this change, but the labels should at least be consistent.