feat(timeline): #IMPULS-5337, add deferred flag for notifications in …#1022
Open
pb-jo wants to merge 21 commits into
Open
Conversation
* feat(timeline): #COCO-5542 add workflow right to authorize beta * clean up
… cron in timeline (#998) * feat(directory,timeline): #COCO-5668 optimize daily and weekly mailer cron in timeline * cleanup * PR review add error / sented result from mass creation * PR review * fix not completing promise on sendMails failure
* fix:#COCO-5619-routing-and-vite-plugins-for-i18n * Update timeline/frontend/vite/plugins/serveLocalI18n.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: use rootDir/server.config.root for deterministic path resolution in serveLocalI18nPlugin Agent-Logs-Url: https://github.com/edificeio/entcore/sessions/62cc8525-387c-4820-9237-2206d05b70ea Co-authored-by: damienromito <603808+damienromito@users.noreply.github.com> * fix typecheck * fix prod front url --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: damienromito <603808+damienromito@users.noreply.github.com>
|
vbillard91
approved these changes
May 12, 2026
jcbe-ode
reviewed
May 13, 2026
Contributor
jcbe-ode
left a comment
jcbe-ode
left a comment
There was a problem hiding this comment.
A faire si possible avant merge
|
|
||
| if (isQuiet) { | ||
| JsonObject recipient = recipientById.get(userId); | ||
| if (recipient != null) recipient.put("deferredToDaily", true); |
Contributor
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "deferredToDaily" 3 times.
jenkinsEdificePublic
force-pushed
the
develop-b2school
branch
2 times, most recently
from
5605da3 to
63be66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add defered flag for notifications in quiet hours.
Fixes
#IMPULS-5337
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃