fix: validate revised body so get keeps stable JSON shape#3
Merged
Conversation
revise persisted req.patch.body unchecked, so a malformed body (e.g. a list) corrupted the record and made body switch from object to array on a subsequent get. Validate the successor draft before persisting, mirroring remember. Fixes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Per #2: after
remember,getreturnsbodyas a dict ({text: ...}). Afterrevise, a subsequentgetcould returnbodyas a list, changing the output JSON shape.Cause
remembervalidatesbody.text, butrevisestoredreq.patch.bodyunchecked. A malformed patch body (e.g. a list) silently persisted, sogetreturned an array.Fix
Validate the successor draft in
revisewithvalidateDraftbefore persisting, mirroringremember. Invalid bodies are now rejected withinvalid_record; valid revisions keepbodyas an object.Tests
Added regression tests covering valid revise (object preserved) and malformed body (rejected, prior record untouched). Full suite: 54 passing; typecheck clean.
Fixes #2