Conversation
Added `4d20cs>=(1d2+17)`, `4d20cs>=(1d4)`, and `4d20cf<=(1d3)` tests in `evaluator.test.ts`. Pinned the documented draw order: target pool resolves before threshold meta-expression. Asserted threshold meta dice surface in `result.rolls` tagged `meta` and `dropped`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added regression coverage for RNG-consuming
cs/cfthreshold meta-expressions inevaluator.test.ts. The documented draw order inevalCritThreshold(target pool first, then threshold meta) and the corresponding worked example in.claude/rules/rng.mdwere untested — only literal-threshold forms (4d20cs>=(17+2)) were covered, so a future refactor reorderingnextIntcalls inside the crit-threshold path would have passed CI.4d20cs>=(1d2+17)test asserting pool draws [20, 19, 18, 5] before the 1d2 threshold die [2], threshold resolves to 19, andcs>=19flags the first two dice critical.4d20cs>=(1d4)sanity variant with a distinct RNG sequence to avoid one-off coincidence.4d20cf<=(1d3)mirror test pinning the same draw-order contract forcf.result.rolls[0]taggedmeta+dropped, matching the SuccessCount meta-threshold pattern at line 2262.Closes #100
Drafted with AI assistance