Skip to content

fix: update macOS image to latest and simplify colima start command #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttak-apphelix wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: update macOS image to latest and simplify colima start command #206

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5890d4
fix: update macOS image to latest and simplify colima start command
ttak-apphelix Jan 5, 2026
1d22f39
fix: update colima start command to use qemu and specify memory alloc…
ttak-apphelix Jan 5, 2026
f0286ac
fix: update Mac Docker installation to include qemu
ttak-apphelix Jan 5, 2026
b432a2a
fix: update macOS image in CI workflow and simplify colima start command
ttak-apphelix Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/cli-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: linux
image: ubuntu-24.04
- name: mac
image: macos-13
image: macos-latest
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using macos-latest instead of a pinned version like macos-13 introduces unpredictability. When GitHub updates what constitutes "latest", the CI environment will change without any code changes in this repository, potentially causing unexpected test failures. Consider pinning to a specific version (e.g., macos-14 or macos-15) for reproducible CI builds.

Suggested change
image: macos-latest
image: macos-14

Copilot uses AI. Check for mistakes.
python-version:
- '3.11'
fail-fast: false
Expand Down Expand Up @@ -54,8 +54,8 @@ jobs:
- name: Docker installation - Mac
if: ${{ matrix.os.name == 'mac' }}
run: |
brew install colima docker docker-compose
colima start -a vz -m 8 -r docker
brew install qemu colima docker docker-compose
colima start --vm-type qemu --memory 8
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colima start command is missing the runtime specification. The previous command used -r docker to explicitly set the runtime. Without this flag, colima may default to a different runtime (like containerd), which could cause the tests to fail. The runtime flag should be added back.

Suggested change
colima start --vm-type qemu --memory 8
colima start -r docker --vm-type qemu --memory 8

Copilot uses AI. Check for mistakes.
echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV
mkdir -p ~/.docker/cli-plugins
ln -sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from the Apple Virtualization framework (vz) to QEMU may significantly degrade CI performance. The vz VM type uses native Apple Silicon virtualization (when available) which is generally faster than QEMU emulation. Unless there's a specific compatibility issue requiring QEMU, consider keeping the vz VM type for better performance. Note that vz may require macOS 13 or later, so this change should be coordinated with the macOS image update.

Suggested change
colima start --vm-type qemu --memory 8
echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV
mkdir -p ~/.docker/cli-plugins
ln -sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose
colima start --vm-type vz --memory 8
echo "DOCKER_HOST=unix://${HOME}/.colima/docker.sock" >> $GITHUB_ENV
mkdir -p ~/.docker/cli-plugins
ln-sfn /usr/local/bin/docker-compose ~/.docker/cli-plugins/docker-compose

Copilot uses AI. Check for mistakes.
Expand Down
Loading