feat(chart): add resourcesPreset support (Bitnami-style resource tiers) - #174
Open
danielqb wants to merge 1 commit into
Open
feat(chart): add resourcesPreset support (Bitnami-style resource tiers)#174danielqb wants to merge 1 commit into
danielqb wants to merge 1 commit into
Conversation
Resources for php-fpm, nginx, mariadb, and redis were only configurable as full explicit request/limit blocks. Bitnami charts offer a lighter-weight alternative via a resourcesPreset value (none/nano/micro/small/medium/ large/xlarge/2xlarge) that maps to a predefined table, useful for quick sizing without hand-writing CPU/memory numbers. - Added glpi.resources.preset helper in _helpers.tpl with the same tiers/values as bitnami/common's common.resources.preset, so operators already familiar with that convention get predictable numbers here. - Added glpi.resources helper: renders the explicit `resources` dict if non-empty, otherwise falls back to `resourcesPreset` (renders nothing if both are unset/none). - Added resourcesPreset: "none" alongside the existing resources blocks for glpi.phpfpm, glpi.nginx, mariadb.primary, and redis in values.yaml. Existing concrete resources values are UNCHANGED and still take precedence by default - this is purely additive, zero behavior change unless a user explicitly clears `resources` to use a preset instead. - Updated glpi-deployment.yaml (php-fpm + nginx), mariadb-statefulset.yaml, and redis-deployment.yaml to use the new helper. - helm lint: 0 failures - helm template (default): resources unchanged (1000m/512Mi php-fpm, 500m/256Mi nginx, matches pre-existing values) - helm template --set glpi.phpfpm.resources=null --set glpi.phpfpm.resourcesPreset=large: renders 1.5cpu/3072Mi limits, 1.0cpu/2048Mi requests (matches Bitnami's "large" tier) - helm template --set redis.resources=null (resourcesPreset stays "none" default): no resources block rendered at all
eduardofraga
requested changes
Jul 28, 2026
eduardofraga
left a comment
Contributor
There was a problem hiding this comment.
Move files from kubernetes/glpi/ to helm/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources for php-fpm, nginx, mariadb, and redis were only configurable
as full explicit request/limit blocks. Bitnami charts offer a lighter-weight
alternative via a resourcesPreset value (none/nano/micro/small/medium/
large/xlarge/2xlarge) that maps to a predefined table, useful for quick
sizing without hand-writing CPU/memory numbers.
Added glpi.resources.preset helper in _helpers.tpl with the same
tiers/values as bitnami/common's common.resources.preset, so operators
already familiar with that convention get predictable numbers here.
Added glpi.resources helper: renders the explicit
resourcesdict ifnon-empty, otherwise falls back to
resourcesPreset(renders nothingif both are unset/none).
Added resourcesPreset: "none" alongside the existing resources blocks
for glpi.phpfpm, glpi.nginx, mariadb.primary, and redis in values.yaml.
Existing concrete resources values are UNCHANGED and still take
precedence by default - this is purely additive, zero behavior change
unless a user explicitly clears
resourcesto use a preset instead.Updated glpi-deployment.yaml (php-fpm + nginx), mariadb-statefulset.yaml,
and redis-deployment.yaml to use the new helper.
helm lint: 0 failures
helm template (default): resources unchanged (1000m/512Mi php-fpm,
500m/256Mi nginx, matches pre-existing values)
helm template --set glpi.phpfpm.resources=null --set
glpi.phpfpm.resourcesPreset=large: renders 1.5cpu/3072Mi limits,
1.0cpu/2048Mi requests (matches Bitnami's "large" tier)
helm template --set redis.resources=null (resourcesPreset stays
"none" default): no resources block rendered at all