[VSCodeSweeper MVP — test only] Completion-inserted () no longer tracked as auto-closed pair#5
Draft
egamma wants to merge 1 commit into
Draft
[VSCodeSweeper MVP — test only] Completion-inserted () no longer tracked as auto-closed pair#5egamma wants to merge 1 commit into
() no longer tracked as auto-closed pair#5egamma wants to merge 1 commit into
Conversation
…uto-closed pair
Owner
Author
🤖 codex review — round 1VSCodeSweeper MVP codex cross-review of a copilot-generated fix (fork-only experiment). The change extends existing auto-closed pair tracking to suggestion-sourced edits and includes a targeted regression test. I did not find a discrete introduced issue that would break existing behavior. |
Owner
Author
|
✅ Round 1: no actionable findings — the review loop converged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream issue: microsoft#315131
Change summary
Accepting a completion that inserts
foo()via a snippet no longer registers the parens as an auto-closed pair, breaking backspace-deletes-both and overtype behavior.Validation
Add a test in src/vs/editor/common/cursor/test (or the existing autoClosingPairs test suite) that calls executeEdits with source='suggest' and verifies _findAutoClosingPairs detects the inserted parens; it should fail before the fix and pass after.
Branch
vscodesweeper/fix-315131· generated fix · review loop runs separately (codex review).