Skip to content

[VSCodeSweeper MVP — test only] Completion-inserted () no longer tracked as auto-closed pair#5

Draft
egamma wants to merge 1 commit into
mainfrom
vscodesweeper/fix-315131
Draft

[VSCodeSweeper MVP — test only] Completion-inserted () no longer tracked as auto-closed pair#5
egamma wants to merge 1 commit into
mainfrom
vscodesweeper/fix-315131

Conversation

@egamma

@egamma egamma commented Jul 9, 2026

Copy link
Copy Markdown
Owner

⚠️ VSCodeSweeper MVP — test only. This draft PR was generated by an AI experiment
(vscodesweeper) inside a personal fork. It is
not intended for microsoft/vscode and is not a contribution proposal.

Upstream issue: microsoft#315131

Change summary

Accepting a completion that inserts foo() via a snippet no longer registers the parens as an auto-closed pair, breaking backspace-deletes-both and overtype behavior.

Validation

Add a test in src/vs/editor/common/cursor/test (or the existing autoClosingPairs test suite) that calls executeEdits with source='suggest' and verifies _findAutoClosingPairs detects the inserted parens; it should fail before the fix and pass after.


Branch vscodesweeper/fix-315131 · generated fix · review loop runs separately (codex review).

@egamma egamma added the vscodesweeper-mvp VSCodeSweeper MVP test PR (fork-only) label Jul 9, 2026
@egamma

egamma commented Jul 9, 2026

Copy link
Copy Markdown
Owner Author

🤖 codex review — round 1

VSCodeSweeper MVP codex cross-review of a copilot-generated fix (fork-only experiment).

The change extends existing auto-closed pair tracking to suggestion-sourced edits and includes a targeted regression test. I did not find a discrete introduced issue that would break existing behavior.

@egamma

egamma commented Jul 9, 2026

Copy link
Copy Markdown
Owner Author

✅ Round 1: no actionable findings — the review loop converged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vscodesweeper-mvp VSCodeSweeper MVP test PR (fork-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant