[VSCodeSweeper MVP — test only] Fix a browser sniff for Firefox support of async clipboard#7
Draft
egamma wants to merge 1 commit into
Draft
[VSCodeSweeper MVP — test only] Fix a browser sniff for Firefox support of async clipboard#7egamma wants to merge 1 commit into
egamma wants to merge 1 commit into
Conversation
Owner
Author
🤖 codex review — round 1VSCodeSweeper MVP codex cross-review of a copilot-generated fix (fork-only experiment). No actionable correctness issues were identified in the diff. The change cleanly factors paste support detection for testing and removes the Firefox exclusion as intended. |
Owner
Author
|
✅ Round 1: no actionable findings — the review loop converged. |
Owner
Author
🤖 codex reviewVSCodeSweeper MVP review of the generated fix (fork-only experiment). Findings, if any, are for a human to triage — nothing is auto-addressed. The patch can falsely enable the Paste command in browsers with partial Clipboard API support, causing a visible command that cannot paste. The support check should match the readText capability used by the paste implementation. Review comment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream issue: microsoft#184958
Change summary
Firefox users on vscode.dev cannot paste because a stale browser sniff bypasses the async clipboard API detection.
Validation
Remove the
|| browser.isFirefoxcondition from thesupportsPastedeclaration and verify the existing clipboard unit tests still pass viascripts/test.sh --grep clipboard; additionally confirm that no other code path relies onsupportsPastebeing false for Firefox.Branch
vscodesweeper/fix-184958· generated fix · review loop runs separately (codex review).