perf(PFRICH): share single HRPPD logical volume across all 68 placements#1116
Open
wdconinc wants to merge 2 commits into
Open
perf(PFRICH): share single HRPPD logical volume across all 68 placements#1116wdconinc wants to merge 2 commits into
wdconinc wants to merge 2 commits into
Conversation
Create one template HRPPD volume with all sub-components (window, photocathode, absorber, ceramic, plating, MCP, PCB) before the placement loop. Place it 68 times with per-module addPhysVolID. This reduces ~544 unique TGeoVolume objects to ~9, shrinking the logical-volume tree and reducing memory/navigation overhead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes pfRICH geometry construction by building one shared HRPPD logical volume and reusing it for all module placements while preserving per-module readout identity through placement physVolIDs.
Changes:
- Hoists HRPPD sub-volume construction out of the placement loop.
- Places the shared HRPPD volume 68 times with unique
"hrppd"physical volume IDs. - Computes sensor IDs directly from the module index and attaches DetElements to the concrete HRPPD placements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Share a single HRPPD logical volume (and its 7 sub-component volumes) across all 68 HRPPD placements
in the pfRICH detector, rather than creating 68×8 = ~544 identical TGeoVolume objects. Each placement
retains its unique
physVolID(\"hrppd\", imod)so readout segmentation is unaffected.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
GitHub Copilot was used to identify the pattern and draft the refactoring.