perf(geometry): disambiguate repeated slice volume names#1119
Open
wdconinc wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Disambiguates repeated slice volume names in two calorimeter geometry plugins by prefixing the parent layer name, making the produced TGeoVolume names unique per layer and easing geometry graph inspection without altering placement or sharing semantics.
Changes:
- Prefix slice names with
l_nameinPolyhedraEndcapCalorimeter2_geo.cpp. - Prefix slice names with
l_nameinBarrelCalorimeterScFi_geo.cpp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PolyhedraEndcapCalorimeter2_geo.cpp | Slice name now includes layer name (e.g., layerN_sliceM). |
| src/BarrelCalorimeterScFi_geo.cpp | Slice name now includes layer name (e.g., layerN_sliceM). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
topic: barrel
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This disambiguates repeated logical-volume slice names in the two geometry plugins that were producing distinct TGeoVolume objects all named
slice1,slice2, etc. Slice names now include the layer name inBarrelCalorimeterScFi_geo.cppandPolyhedraEndcapCalorimeter2_geo.cpp, which makes geometry graph output easier to interpret without changing geometry placement or sharing behavior.Investigation notes:
InsertCalorimeter_geo.cppalready useslayer_name + slice%d, so its slice names were not the source of the ambiguousslice1labels.InsertCalorimeter_geo.cpp, the beampipe hole radius/position is recomputed fromz_distance_traversedfor every layer, so those slice solids are not shareable across repeated layers.slice1volumes instead came from other calorimeter plugins with genericslice%dnames.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
AI usage: GitHub Copilot CLI was used to investigate the geometry naming issue, implement the naming updates, and run a full CMake build check after the change.